Skip to content

Fix: Solve 204 No Content Error #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdalvar3z wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Solve 204 No Content Error #467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5db06a
fix: Solve 204 No Content Error
jdalvar3z Oct 22, 2025
35efa2a
fix: Solve 204 No Content Error
jdalvar3z Oct 22, 2025
4af65f6
fix: Solve 204 No Content Error
jdalvar3z Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions core/src/main/java/com/android/volley/toolbox/JsonObjectRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.android.volley.toolbox;

import androidx.annotation.Nullable;
import com.android.volley.Cache;
import com.android.volley.NetworkResponse;
import com.android.volley.ParseError;
import com.android.volley.Response;
Expand Down Expand Up @@ -90,17 +91,18 @@ public JsonObjectRequest(

@Override
protected Response<JSONObject> parseNetworkResponse(NetworkResponse response) {
Cache.Entry cacheHeaders = HttpHeaderParser.parseCacheHeaders(response);
try {
if (response.data == null || response.data.length == 0) {
return Response.success(new JSONObject(), cacheHeaders);
}
String jsonString =
new String(
response.data,
HttpHeaderParser.parseCharset(response.headers, PROTOCOL_CHARSET));
return Response.success(
new JSONObject(jsonString), HttpHeaderParser.parseCacheHeaders(response));
} catch (UnsupportedEncodingException e) {
return Response.success(new JSONObject(jsonString), cacheHeaders);
} catch (UnsupportedEncodingException | JSONException e) {
return Response.error(new ParseError(e));
} catch (JSONException je) {
return Response.error(new ParseError(je));
}
}
}