Skip to content

chore: update dotnet monorepo to v10 (major) #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −20
Open

chore: update dotnet monorepo to v10 (major) #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4cc69c
chore: update dotnet monorepo to v10
renovate-bot Nov 18, 2025
21fb121
chore: update to .NET 10 and EF10
olavloite Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 10.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-on-emulator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 10.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-on-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 10.0.x
- id: 'auth'
uses: 'google-github-actions/auth@v3'
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 10.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion ...ameworkCore.Spanner.Benchmarks/Google.Cloud.EntityFrameworkCore.Spanner.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions ...Spanner.IntegrationTests/Google.Cloud.EntityFrameworkCore.Spanner.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>

<IsPackable>false</IsPackable>

Expand All @@ -19,8 +19,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="8.0.22" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="8.0.22">
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="10.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion Google.Cloud.EntityFrameworkCore.Spanner.IntegrationTests/QueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ public async Task CanUseStringFormat()

var formattedName = await db.Singers
.Where(s => new long[] { singerId }.Contains(s.SingerId))
.Select(s => string.Format("String without formatting"))
.Select(s => string.Format("{0}", "String without formatting"))
.FirstOrDefaultAsync();
Assert.Equal("String without formatting", formattedName);

Expand Down
4 changes: 2 additions & 2 deletions ...tityFrameworkCore.Spanner.Samples/Google.Cloud.EntityFrameworkCore.Spanner.Samples.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<AssemblyName>SampleRunner</AssemblyName>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand All @@ -24,7 +24,7 @@

<ItemGroup>
<PackageReference Include="Docker.DotNet" Version="3.125.15" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.22">
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
6 changes: 3 additions & 3 deletions ...d.EntityFrameworkCore.Spanner.Tests/Google.Cloud.EntityFrameworkCore.Spanner.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>

<IsPackable>false</IsPackable>

Expand All @@ -18,11 +18,11 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.22">
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="8.0.22" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="10.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="Xunit.Combinatorial" Version="1.6.24" />
Expand Down
10 changes: 5 additions & 5 deletions Google.Cloud.EntityFrameworkCore.Spanner/Google.Cloud.EntityFrameworkCore.Spanner.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Description>Google Cloud Spanner database provider for Entity Framework Core.</Description>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<AssemblyName>Google.Cloud.EntityFrameworkCore.Spanner</AssemblyName>
<RootNamespace>Google.Cloud.EntityFrameworkCore.Spanner</RootNamespace>
<LangVersion>latest</LangVersion>
Expand All @@ -21,11 +21,11 @@
<ItemGroup>
<PackageReference Include="Google.Cloud.Spanner.Data" Version="5.7.0"/>
<PackageReference Include="JetBrains.Annotations" Version="2024.3.0" PrivateAssets="All"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.22" PrivateAssets="All"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="8.0.22"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="8.0.22"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.0" PrivateAssets="All"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Proxies" Version="10.0.0"/>
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.0"/>
<PackageReference Include="OpenTelemetry.Api" Version="1.14.0"/>
<PackageReference Include="System.Text.Json" Version="8.0.6"/>
<PackageReference Include="System.Text.Json" Version="10.0.0"/>
</ItemGroup>

<ItemGroup>
Expand Down
14 changes: 14 additions & 0 deletions Google.Cloud.EntityFrameworkCore.Spanner/Migrations/Internal/SpannerHistoryRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
using Microsoft.EntityFrameworkCore.Storage;
using System;
using System.Text;
using System.Threading;
using System.Threading.Tasks;

namespace Google.Cloud.EntityFrameworkCore.Spanner.Migrations.Internal
{
Expand Down Expand Up @@ -68,6 +70,18 @@ protected override string ExistsSql
/// </summary>
protected override bool InterpretExistsResult(object value) => (bool)value;

public override LockReleaseBehavior LockReleaseBehavior => LockReleaseBehavior.Explicit;

public override IMigrationsDatabaseLock AcquireDatabaseLock()
{
throw new NotImplementedException();
}

public override Task<IMigrationsDatabaseLock> AcquireDatabaseLockAsync(CancellationToken cancellationToken = new CancellationToken())
{
throw new NotImplementedException();
}

/// <summary>
/// This is internal functionality and not intended for public use.
/// </summary>
Expand Down
3 changes: 2 additions & 1 deletion Google.Cloud.EntityFrameworkCore.Spanner/Storage/Internal/SpannerRelationalConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ public ISpannerRelationalConnection CreateMasterConnection()
Dependencies.ConnectionStringResolver,
Dependencies.RelationalTransactionFactory,
Dependencies.CurrentContext,
Dependencies.RelationalCommandBuilderFactory);
Dependencies.RelationalCommandBuilderFactory,
Dependencies.ExceptionDetector);
#pragma warning restore EF1001
return new SpannerRelationalConnection(dependencies);
}
Expand Down
Loading