Skip to content

chore: update dependency alpha.google.cloud.spanner.dataprovider to 1.0.0-alpha.20260123102444 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate-bot wants to merge 1 commit into from
Closed

chore: update dependency alpha.google.cloud.spanner.dataprovider to 1.0.0-alpha.20260123102444 #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spanner-ado-net/spanner-ado-net-benchmarks/spanner-ado-net-benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Alpha.Google.Cloud.Spanner.DataProvider" Version="1.0.0-alpha.20251217172149" />
<PackageReference Include="Alpha.Google.Cloud.Spanner.DataProvider" Version="1.0.0-alpha.20260123102444" />
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PackageReference appears to be redundant and could cause issues. The project already includes a ProjectReference to ..\spanner-ado-net\spanner-ado-net.csproj on line 22, which is the source for the Alpha.Google.Cloud.Spanner.DataProvider package.

Having both can lead to:

  • Versioning Conflicts: The build might use a different version of the package from a NuGet feed instead of the local source code. This PR is an example, as it updates to a version not yet present in the source project.
  • Build Instability: It creates ambiguity for the build system.

To ensure the benchmarks run against the current source code, this PackageReference should be removed. The ProjectReference is sufficient.

<PackageReference Include="Google.Cloud.Monitoring.V3" Version="3.16.0" />
<PackageReference Include="Google.Cloud.Spanner.Data" Version="5.12.0" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="10.1.0" />
Expand Down