feat: API regeneration: release-2026-04-20.08-02-44#3155
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new Developer Knowledge API (v1alpha) and provides extensive updates across various existing Google Cloud services, including Chrome Management, GKE, Health, and Dataform. Key enhancements involve new resource types like connector configurations and subscribers, along with refined documentation and regional endpoint expansions. The review feedback identifies several improvement opportunities: removing internal LINT.IfChange directives from public API descriptions in Chrome Management, correcting a stray slash typo in the HomeGraph API documentation, and adding a regex pattern for the subscriberId parameter in the Health API to enhance client-side validation.
| "type": "object" | ||
| }, | ||
| "GoogleChromeManagementVersionsV1ConnectorConfigDetails": { | ||
| "description": "The details of the connector config. LINT.IfChange", |
There was a problem hiding this comment.
The description contains an internal lint directive LINT.IfChange. This should be removed from the public API discovery document as it is intended for internal developer use only.
| public virtual string Type { get; set; } | ||
| } | ||
|
|
||
| /// <summary>The details of the connector config. LINT.IfChange</summary> |
There was a problem hiding this comment.
The summary contains an internal lint directive LINT.IfChange. This should be removed from the generated documentation.
/// <summary>The details of the connector config.</summary>| "deviceId": { | ||
| "description": "Required. / Unique identifier for the device.", | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
There is a stray slash / in the description: Required. / Unique identifier. This appears to be a typo in the source API definition.
| /// <summary>Contains the set of events for an item.</summary> | ||
| public class HomeEvents : Google.Apis.Requests.IDirectResponseSchema | ||
| { | ||
| /// <summary>Required. / Unique identifier for the device.</summary> |
There was a problem hiding this comment.
There is a stray slash / in the summary documentation. This typo should be corrected in the source API definition to ensure clean generated code.
/// <summary>Required. Unique identifier for the device.</summary>| "type": "string" | ||
| }, | ||
| "subscriberId": { | ||
| "description": "Optional. The ID to use for the subscriber, which will become the final component of the subscriber's resource name. This value should be 4-36 characters, and valid characters are /[a-z]([a-z0-9-]{2,34}[a-z0-9])/.", |
There was a problem hiding this comment.
The subscriberId parameter has a character constraint mentioned in the description but lacks a corresponding pattern field. Adding a pattern field with the regex ^[a-z]([a-z0-9-]{2,34}[a-z0-9])$ would allow client libraries to perform local validation and provide a better developer experience.
2 participants
Changes in this PR will be published to Nuget on the next release cycle.