fix: Use a single instance of the default serializer#3156
Merged
amanda-tarafa merged 3 commits intogoogleapis:mainfrom Apr 20, 2026
Merged
fix: Use a single instance of the default serializer#3156amanda-tarafa merged 3 commits intogoogleapis:mainfrom
amanda-tarafa merged 3 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates integration tests by replacing the CloudMachineLearningEngine service with BigtableAdmin for path testing, adds a license header to RestPathTests.cs, and optimizes BaseClientService to use a singleton for the JSON serializer. Feedback suggests strengthening translation assertions in DataWrapperTests.cs to include multiple keywords and removing trailing whitespace in RestPathTests.cs.
robertvoinescu-work
approved these changes
Apr 20, 2026
Fixes b/503807131
We get slightly different results every time. Fixes b/504743127
when creating service clients, instead of creating a new one each time, which behaves the same as the single instance that's been created already. Fixes googleapis#3148
amanda-tarafa
force-pushed
the
static-default-serializer
branch
from
5612808 to
a67512d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus, fixes some tests that were failing for unrelated reasons.
Reviewing one commit at a time will be better.