Skip to content

feat: API regeneration: release-2026-04-22.08-02-41#3157

Merged
jskeet merged 5 commits intomainfrom
release-2026-04-22.08-02-41
Apr 22, 2026
Merged

feat: API regeneration: release-2026-04-22.08-02-41#3157
jskeet merged 5 commits intomainfrom
release-2026-04-22.08-02-41

Conversation

@amanda-tarafa
Copy link
Copy Markdown
Contributor

Changes in this PR will be published to Nuget on the next release cycle.

@amanda-tarafa amanda-tarafa requested a review from a team as a code owner April 22, 2026 08:04
@jskeet jskeet merged commit f1d5c91 into main Apr 22, 2026
6 checks passed
@jskeet jskeet deleted the release-2026-04-22.08-02-41 branch April 22, 2026 08:07
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Google API client libraries, including DataManager, Merchant Products (v1 and v1beta), MyBusinessAccountManagement, and SmartDeviceManagement. Key changes include the addition of the datamanager.partnerlink scope, new minimumOrderValues and loyalty program fields in the Merchant API, and various documentation updates and version bumps. Feedback focuses on correcting XML documentation issues, specifically fixing double-escaped ampersands and replacing unsupported markdown-style links with appropriate XML tags.


/// <summary>
/// View, create, or delete your partner links in Google Ads, Marketing Platform (Campaign Manager 360,
/// Search Ads 360, Display &amp;amp; Video 360), and Analytics
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ampersand in the documentation summary appears to be double-escaped (&amp;). In XML documentation, it should be escaped once as & to be correctly rendered as & in IntelliSense.

            /// Search Ads 360, Display &amp; Video 360), and Analytics


/// <summary>
/// View, create, or delete your partner links in Google Ads, Marketing Platform (Campaign Manager 360,
/// Search Ads 360, Display &amp;amp; Video 360), and Analytics
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ampersand in the documentation summary appears to be double-escaped (&amp;). In XML documentation, it should be escaped once as & to be correctly rendered as & in IntelliSense.

            /// Search Ads 360, Display &amp; Video 360), and Analytics

public virtual System.Nullable<long> MinHandlingTime { get; set; }

/// <summary>
/// The [minimum value](https://support.google.com/merchants/answer/16989009) in the cart before a customer can
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation summary uses markdown-style links (e.g., text), which are not natively supported in C# XML documentation and will render as literal text in IntelliSense. Consider using the tag instead.

        /// The <see href="https://support.google.com/merchants/answer/16989009">minimum value</see> in the cart before a customer can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants