docs: update urllib3 docstrings for v2 compatibility #1903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `urllib3.request` module was removed in urllib3 v2.0.0, and `RequestMethods` was moved to a private module `urllib3._request_methods`. This commit updates the docstrings in `google/auth/transport/urllib3.py` to remove references to the now-private `urllib3.request.RequestMethods` class. Instead, it references the public `urllib3.PoolManager` class or the generic request interface, ensuring the documentation remains accurate for both urllib3 v1 and v2 users. This addresses the documentation aspect of PR #1290.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
approved these changes
Dec 23, 2025
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added a commit
that referenced
this pull request
Jan 5, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-auth: 2.46.0</summary> ## [2.46.0](v2.45.0...v2.46.0) (2026-01-05) ### Features * Recognize workload certificate config in has_default_client_cert_source for mTLS for Agentic Identities (#1907) ([0b9107d](0b9107d5)) ### Bug Fixes * Fix test coverage for mtls_helper (#1886) ([02e7163](02e71631)) * use .read() instead of .content.read() in aiohttp transport (#1899) ([12f4470](12f4470f)) * add types to default and verify_token and Request __init__ based on comments in the source code. (#1588) ([59a5f58](59a5f588)) * fix the document of secure_authorized_session (#1536) ([5d00147](5d001470)) * raise RefreshError for missing token in impersonated credentials (#1897) ([94d04e0](94d04e09)) * remove setup.cfg configuration for creating universal wheels (#1693) ([c767531](c767531c)) ### Documentation * update urllib3 docstrings for v2 compatibility (#1903) ([3f1aeea](3f1aeea2)) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates docstrings in
google/auth/transport/urllib3.pyto referenceurllib3.PoolManagerinstead of the removed/privateurllib3.request.RequestMethods, ensuring compatibility withurllib3v2 documentation standards.NOTE: This PR supercedes an older PR #1290, because some of the content or suggested changes in the older PR are overtaken by events and/or been incorporated via other recent PRs.
PR created automatically by Jules for task 17649723998293325458 started by @chalmerlowe