Skip to content

fix(Log4Net): Implement new Append method on GoogleStackDriver #15571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertvoinescu-work merged 1 commit into from
Apr 15, 2026
+6 −0
Merged

fix(Log4Net): Implement new Append method on GoogleStackDriver #15571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apis/Google.Cloud.Logging.Log4Net/Google.Cloud.Logging.Log4Net/GoogleStackdriverAppender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,12 @@ protected override void Append(LoggingEvent loggingEvent)

/// <inheritdoc/>
protected override void Append(LoggingEvent[] loggingEvents)
{
Append((IEnumerable<LoggingEvent>)loggingEvents);
}

/// <inheritdoc/>
protected override void Append(IEnumerable<LoggingEvent> loggingEvents)
{
if (!_isActivated)
Comment on lines +517 to 519
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new Append(IEnumerable<LoggingEvent> loggingEvents) method should ideally include a null check for the loggingEvents parameter before accessing it or checking _isActivated, especially since it is a protected method that could be called by subclasses or directly within the class. Although log4net typically ensures non-null arguments in its pipeline, adding a guard clause improves robustness.

        protected override void Append(IEnumerable<LoggingEvent> loggingEvents)
        {
            if (loggingEvents == null)
            {
                return;
            }
            if (!_isActivated)

{
Expand Down
Loading