feat: API regeneration: 20260420T070058Z#15575
Conversation
feat: new iam v3beta client for AccessPolicies, this is step 4&5 for go/client-user-guide?API_NAME=iam.googleapis.com%09&API_SHORTNAME=iam&API_PATH=google%2Fiam&API_VERSION=v3&PROTO_SERVICE=AccessPolicies#run-api-publish-changelist docs: Updated comments across various messages, fields, enums, and methods in the IAM v3beta API, including PolicyBinding, PolicyKind, ListPolicyBindingsRequest, and SearchTargetPolicyBindingsRequest to improve clarity PiperOrigin-RevId: 901360203 Source-Link: googleapis/googleapis@ef57648
feat: add streaming methods StreamSanitizeUserPrompt and StreamSanitizeModelResponse feat: add GOOGLE_MCP_SERVER enforcement point and McpServerFloorSetting feat: add ZIP type and file_label to ByteData feat: add StreamingMode enum and field to sanitize requests docs: update description for ListLocations and various proto comments PiperOrigin-RevId: 901450528 Source-Link: googleapis/googleapis@16b4737
feat: add streaming methods StreamSanitizeUserPrompt and StreamSanitizeModelResponse feat: add GOOGLE_MCP_SERVER enforcement point and McpServerFloorSetting feat: add ZIP type and file_label to ByteData feat: add StreamingMode enum and field to sanitize requests docs: update description for ListLocations and various proto comments PiperOrigin-RevId: 901450528 Source-Link: googleapis/googleapis@16b4737
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
|
Pull request diff results Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.Iam.V3Beta Finding changes in Google.Cloud.ModelArmor.V1Beta... Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.ModelArmor.V1Beta Finding changes in Google.Developers.Knowledge.V1... |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Google.Developers.Knowledge.V1 and Google.Maps.MapManagement.V2Beta APIs, while also extending Google.Cloud.Iam.V3Beta with access policy management and Google.Cloud.ModelArmor.V1Beta with bidirectional streaming. Feedback identifies a potential bug in the DeveloperKnowledge resource name pattern, where the current single-segment template may fail to parse multi-segment document IDs, leading to runtime errors.
| /// <summary>A resource name with pattern <c>documents/{document}</c>.</summary> | ||
| Document = 1, | ||
| } | ||
|
|
There was a problem hiding this comment.
The resource name pattern documents/{document} uses a single-segment template for the document ID. However, the documentation for Document.Name and the RPC bindings in the proto (e.g., v1/{name=documents/**}) suggest that the document ID (which represents a URI without scheme) can contain multiple segments (slashes).
If the document ID is expected to contain slashes, the pattern in the proto should be updated to documents/{document=**} to ensure that DocumentName.Parse and other resource name utilities correctly handle multi-segment IDs. As currently generated, DocumentName will fail to parse names like documents/docs.cloud.google.com/storage/docs/creating-buckets.
2 participants
Changes in this PR