fix(NLog): Remove WaitAsync for net462 compatibility#15578
Merged
robertvoinescu-work merged 1 commit intogoogleapis:mainfrom Apr 20, 2026
Merged
fix(NLog): Remove WaitAsync for net462 compatibility#15578robertvoinescu-work merged 1 commit intogoogleapis:mainfrom
robertvoinescu-work merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies a unit test in GoogleStackdriverTargetTest.cs by removing a 2-second timeout from a task await operation. The review feedback points out that removing this timeout makes the test susceptible to hanging indefinitely and suggests using the WithCancellationToken extension method to implement a safer cancellable wait.
robertvoinescu-work
force-pushed
the
fix/nLog
branch
from
ad75671 to
ec03465
Compare
amanda-tarafa
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/504722267