fix: for BigQuery.V2, Storage.V1, DataStore.V1, Firestore#15583
Open
robertvoinescu-work wants to merge 4 commits intogoogleapis:mainfrom
Open
fix: for BigQuery.V2, Storage.V1, DataStore.V1, Firestore#15583robertvoinescu-work wants to merge 4 commits intogoogleapis:mainfrom
robertvoinescu-work wants to merge 4 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery client to ensure UseInt64Timestamp is correctly propagated through query options and requests, including setting a default value of true. It also increases the polling timeout for Datastore and Firestore admin operations to 10 minutes and updates Storage integration tests to use a specific bucket. Feedback includes a likely incorrect property assignment in GetQueryResultsOptions, a logic concern regarding the unconditional overwriting of FormatOptions in StatelessQueryOptions, and minor typos in a newly added comment.
…ts to maintain ReadBucket consistency.
28da62d to
52ea248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following:
BigQuery Timestamp Parsing:
System.FormatException: The input string '1.48709313E9' was not in a correct format.UseInt64Timestamptotrue.Firestore & Datastore Database Index Timeouts:
System.TimeoutException: Operation did not complete within the specified expiry timeFirestoreFixtureandDatastoreFixtureto accommodate slower backend indexing.Storage.V1 State Consistency:
ResumeWithPageTokenfailed due to an unexpected object count in the sharedReadBucket:Assert.Equal() Failure: Values differ` <br> `Expected: 6` <br> `Actual: 7ReadBucket.Validations
The corresponding integration and unit tests have been run and successfully pass now.
b/502217142