chore(all): update opentelemetry-go-contrib monorepo #13415
Conversation
ℹ Artifact update noticeFile name: auth/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: bigtable/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: spanner/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: spanner/test/opentelemetry/test/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: storage/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: storage/internal/benchmarks/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
trusted-contributions-gcf
bot
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependencies on the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several opentelemetry-go-contrib dependencies across various modules. The updates to go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc and go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp are the most significant. The otelgrpc update to v0.63.0 is a breaking change as it removes the StreamClientInterceptor function. It also deprecates WithSpanOptions, Extract, and Inject. The otelhttp update removes support for the OTEL_SEMCONV_STABILITY_OPT_IN environment variable. I've added comments to the relevant go.mod files highlighting these changes. Please ensure the codebase is updated to reflect these changes to avoid build failures or unexpected behavior. The other dependency updates appear to be non-breaking.
auth/go.mod
Outdated
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 |
There was a problem hiding this comment.
The update to go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.63.0 is a breaking change. The StreamClientInterceptor function has been removed. If this function is used in the auth module, the build will fail. The following functions are also now deprecated and should be replaced:
WithSpanOptionsExtractInject
Additionally, the update to go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.63.0 removes support for the OTEL_SEMCONV_STABILITY_OPT_IN environment variable, which may alter behavior if it was being used for configuration.
| require ( | ||
| cloud.google.com/go/spanner v1.86.1 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 |
There was a problem hiding this comment.
This update to v0.63.0 of go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc includes a breaking change: the StreamClientInterceptor function has been removed. This may cause these tests to fail if they rely on this function. This version also deprecates WithSpanOptions, Extract, and Inject.
renovate-bot
force-pushed
the
renovate/opentelemetry-go-contrib-monorepo
branch
from
814f344 to
c6526a1
Compare
trusted-contributions-gcf
bot
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
renovate-bot
force-pushed
the
renovate/opentelemetry-go-contrib-monorepo
branch
from
c6526a1 to
e9de870
Compare
trusted-contributions-gcf
bot
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates several OpenTelemetry Go Contrib dependencies across multiple modules. The most significant changes are the upgrade of otelgrpc to v0.64.0 and otelhttp to v0.64.0. The otelgrpc update includes a breaking change with the removal of the Extract and Inject functions. The otelhttp update introduces several deprecations. Please review the specific comments for details on these changes to ensure a smooth upgrade.
| github.com/googleapis/gax-go/v2 v2.15.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.64.0 |
There was a problem hiding this comment.
The update to v0.64.0 of otelgrpc removes the Extract and Inject functions, which were deprecated in v0.42.0. This is a breaking change if the project is still using these functions. The recommended migration is to use a propagation.TextMapPropagator directly.
| go.opentelemetry.io/otel v1.38.0 | ||
| go.opentelemetry.io/otel/sdk v1.38.0 | ||
| go.opentelemetry.io/otel/sdk/metric v1.38.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.64.0 |
There was a problem hiding this comment.
The update to v0.64.0 of otelgrpc removes the Extract and Inject functions, which were deprecated in v0.42.0. This is a breaking change if this test module is still using these functions. The recommended migration is to use a propagation.TextMapPropagator directly.
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.64.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.64.0 |
There was a problem hiding this comment.
This update to v0.64.0 of otelhttp deprecates several functions:
WithRouteTag: The route is now added automatically to spans.WithPublicEndpoint: UseWithPublicEndpointFninstead.DefaultClient,Get,Head,Post,PostForm: Use a custom*http.Clientwithotelhttp.NewTransport(http.DefaultTransport)instead.
While not a breaking change, it is recommended to plan for migration away from these deprecated APIs to avoid issues in future upgrades.
3 participants
This PR contains the following updates:
v1.36.0->v1.39.0v0.61.0->v0.64.0v0.61.0->v0.64.0Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/detectors/gcp)
v1.39.0: /v2.1.0/v0.64.0/v0.33.0/v0.19.0/v0.14.0/v0.12.0/v0.11.0Compare Source
Overview
Added
ParseYAMLingo.opentelemetry.io/contrib/otelconfnow supports environment variables substitution in the format${[env:]VAR_NAME[:-defaultvalue]}. (#6215)http.routemetric attribute togo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux. (#7966)db.client.operation.durationmetric forgo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo. (#7983)WithSpanNameFormatteroption togo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo. (#7986)go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelechoto specify the behavior when an error occurs. (#8025)go.opentelemetry.io/contrib/otelconfto include the v1.0.0-rc2 release candidate of schema which includes backwards incompatible changes. (#8026)go.opentelemetry.io/contrib/otelconf. (#8031)CardinalityLimitsandSpanLimitsto v1.0.0 model ingo.opentelemetry.io/contrib/otelconf. (#8043)BatchLogRecordProcessor,BatchSpanProcessor, andPeriodicMetricReaderto v1.0.0 model ingo.opentelemetry.io/contrib/otelconf. (#8049)TextMapPropagatorto v1.0.0 model ingo.opentelemetry.io/contrib/otelconf. (#8052)jaeger.sampler.type/jaeger.sampler.paramattributes for adaptive sampling support and optionWithAttributesDisabledingo.opentelemetry.io/contrib/samplers/jaegerremote. (#8073)OTEL_EXPERIMENTAL_CONFIG_FILEvia theNewSDKfunction ingo.opentelemetry.io/contrib/otelconf(#8106)OTLPHttpExporter,OTLPGrpcExporter,OTLPGrpcMetricExporterandOTLPHttpMetricExporterto v1.0.0 model ingo.opentelemetry.io/contrib/otelconf. (#8112)AttributeType,AttributeNameValue,SimpleSpanProcessor,SimpleLogRecordProcessor,ZipkinSpanExporter,NameStringValuePair,InstrumentType,ExperimentalPeerInstrumentationServiceMappingElem,ExporterDefaultHistogramAggregation,PullMetricReaderto v1.0.0 model ingo.opentelemetry.io/contrib/otelconf. (#8127)container,host,processresource detectors ingo.opentelemetry.io/contrib/otelconf. (#8180)Changed
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#8035)ReadEventsandWriteEventsconstants ingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpso they can be used inWithMessageEvents. (#8153)OTEL_SEMCONV_STABILITY_OPT_INto emit the v1.37.0 semantic conventions by default ingo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo. Use the environment variableOTEL_SEMCONV_STABILITY_OPT_INto configure duplication with old semantic conventions if needed (i.e.OTEL_SEMCONV_STABILITY_OPT_IN="database/dup"). (#8230)Deprecated
WithRouteTagingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpis deprecated. The route is already added automatically for spans. For metrics, the alternative is to use theWithMetricAttributesFnoption. (#8117)WithPublicEndpointingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpis deprecated. UseWithPublicEndpointFninstead. (#8152)DefaultClient,Get,Head,Post, andPostFormingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpare deprecated. Use a custom*http.Clientwithotelhttp.NewTransport(http.DefaultTransport)instead. (#8140, #8201)Removed
go.opentelemetry.io/contrib/detectors/aws/ec2module, please usego.opentelemetry.io/contrib/detectors/aws/ec2/v2instead. (#7841)ExtractandInjectfunctions fromgo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#7952)What's Changed
ef028d9by @renovate[bot] in #7835d7b6acbby @renovate[bot] in #7840http/dupflag in shared semconv by @dmathieu in #78137fc2783by @renovate[bot] in #78499b996f7by @renovate[bot] in #7862f7b3be9by @renovate[bot] in #78640bf3876by @renovate[bot] in #7869af835b0by @renovate[bot] in #786766792eeby @renovate[bot] in #78719702482by @renovate[bot] in #7880aef8a43by @renovate[bot] in #7879589584fby @renovate[bot] in #7888df92998by @renovate[bot] in #7899context.Background()witht.Context()/b.Context()in tests by @flc1125 in #79109219d12by @renovate[bot] in #792957b25aeby @renovate[bot] in #79588e64475by @renovate[bot] in #79594eae98aby @renovate[bot] in #7963bc988d5by @renovate[bot] in #796827f1f14by @renovate[bot] in #79697c0ddcbby @renovate[bot] in #797365f7160by @renovate[bot] in #798449b9836by @renovate[bot] in #7995d2f985dby @renovate[bot] in #800591c411eby @renovate[bot] in #80089fd1530by @renovate[bot] in #80137e357f2by @renovate[bot] in #801624f779fby @renovate[bot] in #80174626949by @renovate[bot] in #801890e834fby @renovate[bot] in #803688f65dcby @renovate[bot] in #80425be28d7by @renovate[bot] in #80573a174f9by @renovate[bot] in #8058a4bb9ffby @renovate[bot] in #8063Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.