feat: bigquery driver can now limit maxRetries of retryAble errors. When that happens, it returns RetryExhaustedError with all N errors listed.

[nishant-rudderstack]

bigquery driver can now limit maxRetries of retryAble errors. When that happens, it returns RetryExhaustedError with all N errors listed.

[gemini-code-assist]

Summary of Changes

Hello @nishant-rudderstack, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the BigQuery Go client by providing granular control over retry behavior for operations susceptible to transient errors. Previously, retryable operations would continue indefinitely until the context was cancelled. With this change, users can now specify a maximum number of retries, preventing endless loops and enabling more predictable error handling. The new "RetryExhaustedError" provides valuable diagnostic information by aggregating all errors that occurred during the retry sequence, which is crucial for identifying and resolving persistent issues.

Highlights

• Configurable Max Retries: The BigQuery client now supports a "WithMaxRetries" option, allowing users to specify a maximum number of retry attempts for operations encountering retryable errors.
• RetryExhaustedError: A new error type, "RetryExhaustedError", is introduced. When the configured "maxRetries" limit is reached, this error is returned, encapsulating all individual errors encountered during the failed retry attempts for detailed debugging.
• Enhanced Retry Logic: The internal retry mechanism has been upgraded to "RetryN", which accepts the "maxRetries" parameter. If "maxRetries" is 0 or negative, it defaults to the previous behavior of infinite retries until context cancellation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature to limit the maximum number of retries for retryable errors in the BigQuery client. The implementation is thorough, introducing a new WithMaxRetries client option, a corresponding RetryExhaustedError type to collect errors, and a new RetryN internal function. The changes are well-tested. My review includes a critical comment about a local replace directive in go.mod that must be removed. I've also provided some suggestions to improve documentation clarity, remove redundant code, and simplify test helpers for better maintainability.