Skip to content

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jan 6, 2026

This PR migrates presubmit tests to run using gotestsum, and stops the use of go-junit-report to parse logs.

related: b/473558736

This PR migrates presubmit tests to run using gotestsum, and stops
the use of go-junit-report to parse logs.
@shollyman shollyman requested review from a team as code owners January 6, 2026 18:52
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the presubmit test execution script to leverage gotestsum. This change streamlines the process of running Go tests and generating JUnit XML reports, eliminating the need for a separate log parsing step. The primary goal is to modernize and simplify the test infrastructure, making the test output more readable and report generation more efficient.

Highlights

  • Migration to gotestsum: The presubmit tests have been updated to use gotestsum for running Go tests, replacing the direct go test command.
  • Removal of go-junit-report: The separate go-junit-report utility is no longer needed, as gotestsum now directly handles the generation of JUnit XML reports.
  • Streamlined Test Execution: The overall process for executing tests and generating reports in presubmit.sh has been simplified by consolidating steps into gotestsum.
  • Increased Test Timeout: The timeout for short tests has been adjusted from 15 minutes to 45 minutes to accommodate potential longer run times with the new setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the presubmit tests from go test | go-junit-report to gotestsum. The change is straightforward and achieves the goal. I've found one area for improvement regarding code duplication and a potential bug with a test timeout value, for which I've provided a suggestion. Otherwise, the changes look good.

@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2026
@shollyman shollyman changed the title chore: switch presubmit driver to use gotestsum chore: switch presubmit to use gotestsum Jan 7, 2026
@shollyman shollyman merged commit 8657ec2 into googleapis:main Jan 7, 2026
10 checks passed
@shollyman shollyman deleted the gotestsum-testing branch January 7, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants