Skip to content

Conversation

@shollyman
Copy link
Contributor

This PR also modifies some emulator_test.sh driver scripts so that they also use gotestsum.

This PR also modifies some emulator_test.sh driver scripts so that they
also use gotestsum.
@shollyman shollyman requested review from a team as code owners January 7, 2026 17:12
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the Go test execution and reporting mechanism across the continuous integration environment and emulator test scripts by migrating to gotestsum. This change aims to improve the readability of test output, enhance integration with CI systems through standardized JUnit XML reports, and simplify the overall test command structure.

Highlights

  • Continuous Integration Script Update: The internal/kokoro/continuous.sh script has been refactored to utilize gotestsum for running Go tests within the runDirectoryTests function. This change streamlines the test execution and integrates JUnit XML report generation directly through gotestsum.
  • Emulator Test Script Migration: The emulator_test.sh driver scripts for both spanner and storage packages have been updated to use gotestsum instead of direct go test commands. This ensures consistent test execution and reporting across these modules.
  • Simplified JUnit Reporting: The manual go-junit-report step has been removed from internal/kokoro/continuous.sh as gotestsum now handles the generation of sponge_log.xml directly, simplifying the CI pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the continuous integration scripts to use gotestsum instead of go test | go-junit-report. This is a good improvement for standardizing test execution and reporting. My review focuses on ensuring the new gotestsum commands are correctly implemented. I've found a critical issue in spanner/emulator_test.sh where test results are being overwritten, and a couple of other issues related to argument quoting and script consistency. Please see my detailed comments.

@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2026
@shollyman shollyman merged commit 2d71288 into googleapis:main Jan 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants