docs(storage): add samples for generate signed urls#4525
docs(storage): add samples for generate signed urls#4525joshuatants merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4525 +/- ##
==========================================
- Coverage 95.02% 95.01% -0.02%
==========================================
Files 195 195
Lines 7456 7456
==========================================
- Hits 7085 7084 -1
- Misses 371 372 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/storage/examples/src/objects/generate_upload_signed_url_v4.rs
Outdated
Show resolved
Hide resolved
src/storage/examples/src/objects/generate_upload_signed_url_v4.rs
Outdated
Show resolved
Hide resolved
src/storage/examples/src/objects/generate_upload_signed_url_v4.rs
Outdated
Show resolved
Hide resolved
src/storage/examples/src/objects/generate_upload_signed_url_v4.rs
Outdated
Show resolved
Hide resolved
8fecd47 to
d35fb0b
Compare
|
Sorry Carlos some more newbie questions:
(For context, the tests that currently fail are for the samples I suspect this is because I'm currently using the project I set up here. I'm creating a new project but am unsure of what Billing Account and Location to select (screenshot). Is there a sample project I can follow? Thank you. |
Maybe. But I think the testbench is missing some headers that we depend on. But why? The motivations for the testbench are: (1) to avoid flakes because you are using production, (2) to create specific errors. For (2) we decided to launch HTTP (or gRPC) servers from within Rust. It is easy to do, and you can control sequence of messages much better than with the testbench (including timeouts). For (1) same thing, we try to run as few tests as possible against production. I guess the examples could be excluded, but wouldn't you want at least one run against production for the examples? And we only have one-ish test.
You are running into #4370 maybe it would be nice to automatically disable the tracing test if the billing project is not enabled, or disable the gRPC tests if it was. |
Fixed in #4584 |
Fixes #3081
Fixes #3082