Skip to content

feat: add support for remaining map pipeline expressions#2321

Open
dlarocque wants to merge 8 commits intomainfrom
dl/map-expressions
Open

feat: add support for remaining map pipeline expressions#2321
dlarocque wants to merge 8 commits intomainfrom
dl/map-expressions

Conversation

@dlarocque
Copy link
Contributor

Adds support for mapSet, mapKeys, mapValues, mapEntries pipeline expressions.

Adds support for `mapSet`, `mapKeys`, `mapValues`, `mapEntries` pipeline
expressions.
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/java-firestore API. labels Feb 20, 2026
@dlarocque dlarocque added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2026
@dlarocque dlarocque marked this pull request as ready for review February 27, 2026 15:17
@dlarocque dlarocque requested review from a team as code owners February 27, 2026 15:17
/**
* Creates an expression that returns a new map with the specified entries added or updated.
*
* <ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use list?


/**
* Creates an expression that returns the keys of a map.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u added note for these functions in other sdks

Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants