Open
Conversation
product-auto-label
bot
added
size: l
dlarocque
force-pushed
the
dl/string-expressions
branch
from
f294d5a to
b98718f
Compare
dlarocque
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
milaGGL
reviewed
Feb 27, 2026
| } | ||
|
|
||
| /** | ||
| * Creates an expression that removes whitespace from the end of a string or byte array. |
Contributor
There was a problem hiding this comment.
the description is slightly different from the following overload function
milaGGL
reviewed
Feb 27, 2026
| } | ||
|
|
||
| /** | ||
| * Creates an expression that removes trailing whitespace from a string or byte field. |
Contributor
There was a problem hiding this comment.
use "blob" or "byte", stick to one in the descriptions.
milaGGL
approved these changes
Feb 27, 2026
Contributor
milaGGL
left a comment
milaGGL
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds string expressions:
ltrim,rtrim,stringIndexOf,stringReplaceOne,stringReplaceAll,stringRepeat.The
ltrimValueandrtrimValuefunctions exist to avoid duplicate function declarations between the functionsstatic Expression rtrim(Expression: valueToTrim)(trim thevalueToTrimfromthis) andExpression ltrim(Expression: exprToTrim)(trim whitespace fromexprToTrim). This is already done for the existingtrimAPIs here and in Android.Ported from: firebase/firebase-js-sdk#9479