Skip to content

Conversation

@karthitect
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #137 🦕

@karthitect karthitect requested review from a team as code owners October 4, 2025 00:53
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Oct 4, 2025
@rahul2393
Copy link
Contributor

/gcbrun

@rahul2393
Copy link
Contributor

@averikitsch Can you please help with one more approval on this PR
Context: b/431025682

@rahul2393 rahul2393 changed the title Fix issue #137 docs: fix jupyter notebook steps Nov 5, 2025
@rahul2393
Copy link
Contributor

@averikitsch
I see these errors in checks

E           google.api_core.exceptions.NotFound: 404 Publisher Model `projects/langchain-spanner-testing/locations/us-central1/publishers/google/models/gemini-1.5-flash-002` was not found or your project does not have access to it. Please ensure you are using a valid model version. For more information, see: https://cloud.google.com/vertex-ai/generative-ai/docs/learn/model-versions
>           raise exceptions.from_grpc_error(exc) from exc
        except grpc.RpcError as exc:
            return callable_(*args, **kwargs)
        try:
    def error_remapped_callable(*args, **kwargs):
    @functools.wraps(callable_)

kwargs = {'metadata': [('x-goog-request-params', 'model=projects/langchain-spanner-testing/locations/us-central1/publishers/goo...ython/3.12.12 grpc/1.76.0 gax/2.28.1 gccl/2.0.27-langchain-google-vertexai/2.0.27-ChatVertexAI_gemini-1.5-flash-002')]}
,)

"execution_count": 29,
"metadata": {},
"outputs": [],
"outputs": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the outputs to ensure this is a clean view?

@averikitsch
Copy link
Collaborator

@rahul2393 can you update the tests that use the outdated model?

@averikitsch
Copy link
Collaborator

Please ping me when ready for a review

@rahul2393
Copy link
Contributor

@averikitsch what should I update it with? is there a new value which I need to use?

@rahul2393
Copy link
Contributor

I created PR to update tests #201

@averikitsch
Copy link
Collaborator

/gcbrun

@rahul2393
Copy link
Contributor

@averikitsch Any idea on why tests are still failing?

@rahul2393
Copy link
Contributor

@karthitect please fix the lint

would reformat /home/runner/work/langchain-google-spanner-python/langchain-google-spanner-python/samples/langchain_quick_start.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

samples: Jupyter Notebook "#Try-inserting-the-documents-into-the-vector-table" is incompatible with the actual code and fails

4 participants