feat(migrate/python): use BUILD.bazel for Python libraries#3893
feat(migrate/python): use BUILD.bazel for Python libraries#3893jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
|
(This will be a draft until #3890 is merged, at which point I'll rebase and there'll be a single commit when I request a review.) |
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to use BUILD.bazel files for configuring Python library generation during migration. The changes are well-implemented and include comprehensive tests. My feedback focuses on improving error handling by wrapping errors with more context to aid in debugging. Overall, the implementation is solid and aligns with the project's coding style.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3893 +/- ##
==========================================
+ Coverage 83.37% 83.47% +0.09%
==========================================
Files 69 69
Lines 6173 6234 +61
==========================================
+ Hits 5147 5204 +57
- Misses 669 671 +2
- Partials 357 359 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2daaf02 to
2f867df
Compare
|
@zhumin8: I'm definitely expecting to want to change this and the generator code together when your work on transports is done, but I'd like to get what I've got merged (as it does more than just transports) rather than have two moving targets to balance at the same time, if that's okay. |
Uses BUILD.bazel files on all APIs associated with a library to: - Pick up Python-specific GAPIC generator arguments - Pick up when rest_numeric_enums is false (specified in the same way) - Detect when the transport varies by API or is consistently not grpc+rest - Detect non-GAPIC API paths
Uses BUILD.bazel files on all APIs associated with a library to:
Some of this may become obsolete due to #3897 but we can address that when everything has landed.
Fixes #3407.