refactor(librarian/rust): migrate generator to use ModelConfig#3946
Open
jameslynnwu wants to merge 2 commits intomainfrom
Open
refactor(librarian/rust): migrate generator to use ModelConfig#3946jameslynnwu wants to merge 2 commits intomainfrom
jameslynnwu wants to merge 2 commits intomainfrom
Conversation
…elConfig This commit updates the rust generators to use ModelConfig. This resolves an issue where generate.go had an implicit dependency on parser configuration struct.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Rust generator to use ModelConfig, which is a good step towards simplifying configuration handling. The changes are mostly correct and consistent. I've identified a few areas for improvement, including a redundant function call, some inefficient code patterns that can be optimized, and a test case name that has become misleading.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 69 69
Lines 6188 6188
=======================================
Hits 5158 5158
Misses 671 671
Partials 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the rust generators to use ModelConfig. Will migrate rust veneer generation afterwards
Part of #3662