chore: replace old python teams with cloud-sdk-python-team#207
chore: replace old python teams with cloud-sdk-python-team#207suztomo wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes and updates the references to the Python development team across various repository configuration files. By replacing outdated team names with Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Python team owners from @googleapis/yoshi-python and @googleapis/python-core-client-libraries to @googleapis/cloud-sdk-python-team across various configuration files. The changes are mostly correct, but I've identified a duplicated team entry in the .github/CODEOWNERS file that should be addressed.
.github/CODEOWNERS
Outdated
| # @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team @googleapis/api-bigquery-dataframe are the default owners for changes in this repo | ||
| * @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team @googleapis/api-bigquery-dataframe |
There was a problem hiding this comment.
The team @googleapis/cloud-sdk-python-team is duplicated in both the comment and the rule. This is likely a result of the autogeneration process replacing two old teams with the same new one. Please remove the duplicate entry. You might need to adjust the configuration for the generation script to prevent this from happening again.
# @googleapis/cloud-sdk-python-team @googleapis/api-bigquery-dataframe are the default owners for changes in this repo
* @googleapis/cloud-sdk-python-team @googleapis/api-bigquery-dataframe
72a4904 to
2d37abe
Compare
Bug ID: b/479543683