Skip to content

Conversation

@KasiaStrz
Copy link

Fixes b/452032333.

@KasiaStrz KasiaStrz requested review from a team as code owners November 18, 2025 10:29
@KasiaStrz KasiaStrz requested a review from iennae November 18, 2025 10:29
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 18, 2025
@snippet-bot
Copy link

snippet-bot bot commented Nov 18, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Nov 18, 2025
daniel-sanche
daniel-sanche previously approved these changes Nov 21, 2025
@daniel-sanche daniel-sanche enabled auto-merge (squash) November 21, 2025 17:49
chalmerlowe
chalmerlowe previously approved these changes Nov 24, 2025
Copy link

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2025
gkevinzheng
gkevinzheng previously approved these changes Nov 24, 2025
auto-merge was automatically disabled December 3, 2025 17:23

Head branch was pushed to by a user without write access

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 3, 2025
@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 3, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 3, 2025
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at it again, are you sure this is doing what you want? This new sample isn't just an async version of write_increment, AddToCell is related to aggregates, which is something totally different.

If this sample is just for incrementing a value, we can probably close this, because we have that sample here

If this is supposed to be an AddToCell/aggregation sample, we should give this a different name to be more distinct, and probably move this to the data_client folder with the others. And we may have to do some work in the test project, because I don't think the test cluster is currently set up to work with aggregate families

Sorry for not catching this earlier. Let me know how you want to proceed

@daniel-sanche
Copy link
Contributor

Following up offline, this is intended to be an aggregation test. So we'll need to:

  • change the region tag to bigtable_writes_aggregate
  • move the tests to the data folder
  • set up test families that are configured for aggregations

I'm going to take over this PR to get the last pieces through (Thanks @KasiaStrz!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants