-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Add async sample for incrementing a value #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Head branch was pushed to by a user without write access
33e6fa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking at it again, are you sure this is doing what you want? This new sample isn't just an async version of write_increment, AddToCell is related to aggregates, which is something totally different.
If this sample is just for incrementing a value, we can probably close this, because we have that sample here
If this is supposed to be an AddToCell/aggregation sample, we should give this a different name to be more distinct, and probably move this to the data_client folder with the others. And we may have to do some work in the test project, because I don't think the test cluster is currently set up to work with aggregate families
Sorry for not catching this earlier. Let me know how you want to proceed
|
Following up offline, this is intended to be an aggregation test. So we'll need to:
I'm going to take over this PR to get the last pieces through (Thanks @KasiaStrz!) |
Fixes b/452032333.