-
Notifications
You must be signed in to change notification settings - Fork 83
chore: import main into pipeline-preview branch #1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pipeline-preview
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a significant set of updates from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request brings the branch up to date with a large number of changes from the main branch. Key updates include adding support for Python 3.14, introducing new API methods like CloneDatabase and ExecutePipeline, and adding mTLS support. The code generation tooling has also been migrated from OwlBot to Librarian.
My review focuses on the manual changes and patterns in the generated code. I've found a critical issue in the REST transport implementation for streaming RPCs, where newly added logging code is unreachable. I've also noted a medium-severity issue in a test where a RuntimeWarning is suppressed, which could be handled more cleanly.
Overall, the changes are extensive and mostly look good, but the issue in the REST transport needs to be addressed.
| if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor( | ||
| logging.DEBUG | ||
| ): # pragma: NO COVER | ||
| http_response = { | ||
| "headers": dict(response.headers), | ||
| "status": response.status_code, | ||
| } | ||
| _LOGGER.debug( | ||
| "Received response for google.firestore_v1.FirestoreClient.batch_get_documents", | ||
| extra={ | ||
| "serviceName": "google.firestore.v1.Firestore", | ||
| "rpcName": "BatchGetDocuments", | ||
| "metadata": http_response["headers"], | ||
| "httpResponse": http_response, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logging block appears to be unreachable. The __call__ method for _BatchGetDocuments is a generator that yields responses from within a loop. Any code after this loop, including this logging block, will not be executed. The logging should be performed inside the loop for each response that is yielded.
This same issue exists for _ExecutePipeline, _RunAggregationQuery, and _RunQuery in this file.
| @pytest.mark.filterwarnings( | ||
| "ignore:coroutine method 'aclose' of 'AsyncIter' was never awaited:RuntimeWarning" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppressing this RuntimeWarning might hide a potential issue with resource management in the test. While this might be acceptable for this specific test, it would be better to explicitly close the async generator to avoid the warning and ensure resources are cleaned up properly. For example, you could explicitly call await stream.aclose() in a finally block.
Catch back up with changes on main branch