fix: enable filtering on UserProperty fields#1004
Open
yihaoWang wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: enable filtering on UserProperty fields#1004yihaoWang wants to merge 1 commit intogoogleapis:mainfrom
yihaoWang wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Fix UserProperty query functionality by properly handling meanings at the entity's top level. Previously, UserProperty fields could not be used in queries because the _MEANING_PREDEFINED_ENTITY_USER was not being set correctly in the outer layer of the property.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where filtering queries on UserProperty fields was not working. The root cause was that the
_MEANING_PREDEFINED_ENTITY_USERmeaning was not being properly set at the entity's top level during query filter creation.In the Google Datastore, UserProperty meanings are stored at the entity's top level rather than within individual property values. This PR adds the necessary handling to ensure the meaning is correctly propagated when creating filters for UserProperty fields.
Changes
_comparisonmethod toUserPropertyclass to set the proper meaning during filter creationTesting
To reproduce and verify the fix: