Skip to content

Documentation: Improve Docstrings in modules google/pubsub_v1/services/subscriber#1021

Closed
gentris wants to merge 1 commit intogoogleapis:mainfrom
gentris:fix-subscriber-docstrings
Closed

Documentation: Improve Docstrings in modules google/pubsub_v1/services/subscriber#1021
gentris wants to merge 1 commit intogoogleapis:mainfrom
gentris:fix-subscriber-docstrings

Conversation

@gentris
Copy link

@gentris gentris commented Nov 6, 2023

Improves docstrings on the following modules, by replacing returns with raises:

  • google/pubsub_v1/services/subscriber/async_client.py
  • google/pubsub_v1/services/subscriber/client.py
  • google/pubsub_v1/services/subscriber/transports/grpc.py
  • google/pubsub_v1/services/subscriber/transports/grpc_asyncio.py

Fixes #1020 🦕

@gentris gentris requested a review from a team as a code owner November 6, 2023 08:38
@gentris gentris requested a review from a team November 6, 2023 08:38
@google-cla
Copy link

google-cla bot commented Nov 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 6, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Nov 6, 2023
@mukund-ananthu mukund-ananthu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 7, 2024
@parthea
Copy link
Contributor

parthea commented Feb 26, 2026

Closing stale PRs to prepare for the code migration to google-cloud-python. Please feel free to re-open this PR if this is actively being worked on, or open a new PR after the code has migrated to google-cloud-python.

@parthea parthea closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inaccurate Dosctrings in Modules: google/pubsub_v1/services/subscriber

4 participants