This repository was archived by the owner on Apr 27, 2021. It is now read-only.
Move enqueueRemovingDeviceTokens out of for loop#11
Open
yiqingzhao wants to merge 1 commit intogooglearchive:masterfrom
yiqingzhao:master
Open
Move enqueueRemovingDeviceTokens out of for loop#11yiqingzhao wants to merge 1 commit intogooglearchive:masterfrom yiqingzhao:master
yiqingzhao wants to merge 1 commit intogooglearchive:masterfrom
yiqingzhao:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the enqueueRemovingDeviceTokens should be placed out of the for loop. Otherwise it will be called multiple times with duplicated device tokens among the enqueue requests instead of a one off request.