support Variable length indexPaths

[schriftgestalt]

No description provided.

[madig]

What's a variable length indexPath, what's it used for and do you have an example file where it is used?

[schriftgestalt]

Hints can have index paths with two, three (a link to the side bearing) or four (a implicit node at intersection of two segments) indexes.

[madig]

Do you have an example file that exercises the possibilities?

[schriftgestalt]

IndexPathExample.glyphs.zip

[jenskutilek]

I just hit the same problem when trying to build a hinted font with fontmake. In case it helps, this is the link to the glyphs file: SudoVariable.glyphs

fontmake -g SudoVariable.glyphs -o variable
[...]
File "/Users/jens/Library/Python/3.7/lib/python/site-packages/glyphsLib/types.py", line 100, in fromString
    return [float(i) for i in self.regex.match(src).groups()]
AttributeError: 'NoneType' object has no attribute 'groups'

[madig]

Noted, but didn't have the time to look at this yet...

[madig]

@schriftgestalt Loading the file you supplied results in

Traceback (most recent call last):
  File "C:\UsersLocal\nikolaus.waxweiler\Envs\glyphsLib\Scripts\glyphs2ufo-script.py", line 11, in <module>
    load_entry_point('glyphsLib', 'console_scripts', 'glyphs2ufo')()
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\cli.py", line 198, in _glyphs2ufo_entry_point
    return main(args)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\cli.py", line 161, in main
    return options.func(options)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\cli.py", line 190, in glyphs2ufo
    store_editor_state=not options.no_store_editor_state,
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\__init__.py", line 110, in build_masters
    font = GSFont(filename)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\classes.py", line 3204, in __init__
    p.parse_into_object(self, fp.read())
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 63, in parse_into_object
    i = self._parse_dict_into_object(res, text, 1)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 164, in _parse_dict_into_object
    result = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 101, in _parse
    return self._parse_list(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 191, in _parse_list
    list_item, i = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 95, in _parse
    return self._parse_dict(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 148, in _parse_dict
    i = self._parse_dict_into_object(res, text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 164, in _parse_dict_into_object
    result = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 101, in _parse
    return self._parse_list(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 191, in _parse_list
    list_item, i = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 95, in _parse
    return self._parse_dict(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 148, in _parse_dict
    i = self._parse_dict_into_object(res, text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 164, in _parse_dict_into_object
    result = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 101, in _parse
    return self._parse_list(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 191, in _parse_list
    list_item, i = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 95, in _parse
    return self._parse_dict(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 148, in _parse_dict
    i = self._parse_dict_into_object(res, text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 164, in _parse_dict_into_object
    result = self._parse(text, i)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\parser.py", line 123, in _parse
    value = self.current_type(value)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\types.py", line 50, in __init__
    self.value = self.fromString(value)
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\types.py", line 177, in fromString
    return [int(i) for i in elements]
  File "c:\userslocal\nikolaus.waxweiler\development\glyphslib\lib\glyphsLib\types.py", line 177, in <listcomp>
    return [int(i) for i in elements]
ValueError: invalid literal for int() with base 10: 'lsb'

What else do we need to implement here?

[schriftgestalt]

The hint.originIndex can start be "lsb" or "rsb" instead of an int. I didn't like some obscure int constants. This makes it easier to read for humans but less so for machines it seems.