Fix brace layer parsing to force int where there may be strings#783
Open
jpt wants to merge 1 commit intogooglefonts:mainfrom
Open
Fix brace layer parsing to force int where there may be strings#783jpt wants to merge 1 commit intogooglefonts:mainfrom
jpt wants to merge 1 commit intogooglefonts:mainfrom
Conversation
Member
|
i'm not sure the fix is correct. Can you provide a reproducer? |
Author
|
I'll work on putting together a minimal file that can reproduce this, thanks for looking into it |
Contributor
|
For what it is worth: we also ran into this issue with one of our families. It seems the most recent (unreleased) Glyphs version 3.2 automatically fixes this upon saving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into this error while converting a file that uses brace layers:
The issue was that my Glyphs file had some integers in its brace layer axis locations, along with some strings. I'm not sure how or why this divergence occurred, but I think it would make sense to force an
intfor these values.