Skip to content

fix: add google.maps.Animation mock#1066

Merged
usefulthink merged 1 commit intogooglemaps:mainfrom
Green00101:fix-google-maps-animation
May 1, 2026
Merged

fix: add google.maps.Animation mock#1066
usefulthink merged 1 commit intogooglemaps:mainfrom
Green00101:fix-google-maps-animation

Conversation

@Green00101
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #332 🦕

This PR adds the missing google.maps.Animation mock with BOUNCE and DROP constants.

After calling initialize(), users can now access:

google.maps.Animation.BOUNCE
google.maps.Animation.DROP

This fixes the issue where code using google.maps.Animation.BOUNCE could fail in tests because google.maps.Animation was not defined.

This PR also adds tests to verify that google.maps.Animation is initialized with BOUNCE and DROP.

Tests passed:

  • npm test
  • npm run lint

I am happy to update the code if any changes are needed.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 30, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@usefulthink usefulthink merged commit bd2a5ce into googlemaps:main May 1, 2026
13 checks passed
github-actions Bot pushed a commit that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google.maps.Animation missing

2 participants