Skip to content

fix(gmail): remove duplicate attachment arg on +send #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpoehnelt merged 1 commit into from
Mar 18, 2026
Merged

fix(gmail): remove duplicate attachment arg on +send #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-send-attachment-arg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@googleworkspace/cli": patch
---

fix(gmail): remove dead `--attachment` arg from `+send`

The `+send` subcommand defined a duplicate `"attachment"` arg alongside the
`"attach"` arg already provided by `common_mail_args`. Since `parse_attachments`
reads `"attach"`, the `--attachment` flag was silently ignored. Removed the
dead duplicate.
1 change: 0 additions & 1 deletion skills/gws-gmail-send/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ gws gmail +send --to <EMAILS> --subject <SUBJECT> --body <TEXT>
| `--subject` | ✓ | — | Email subject |
| `--body` | ✓ | — | Email body (plain text, or HTML with --html) |
| `--from` | — | — | Sender address (for send-as/alias; omit to use account default) |
| `--attachment` | — | — | Attach a file (can be repeated for multiple files) |
| `--attach` | — | — | Attach a file (can be specified multiple times) |
| `--cc` | — | — | CC email address(es), comma-separated |
| `--bcc` | — | — | BCC email address(es), comma-separated |
Expand Down
7 changes: 0 additions & 7 deletions src/helpers/gmail/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,13 +922,6 @@ impl Helper for GmailHelper {
.long("from")
.help("Sender address (for send-as/alias; omit to use account default)")
.value_name("EMAIL"),
)
.arg(
Arg::new("attachment")
.long("attachment")
.help("Attach a file (can be repeated for multiple files)")
.action(ArgAction::Append)
.value_name("PATH"),
),
)
.after_help(
Expand Down
Loading