Skip to content

fix(setup): handle --help explicitly in setup flow#535

Open
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/issue-280-setup-help-v2
Open

fix(setup): handle --help explicitly in setup flow#535
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/issue-280-setup-help-v2

Conversation

@dumko2001
Copy link
Contributor

@dumko2001 dumko2001 commented Mar 18, 2026

Description

Explicitly handle --help or -h flags in the gws auth setup command before any logic is executed. This prevents the command from accidentally triggering GCP project creation or other side effects when a user is merely seeking usage information.

Fixes #280

Dry Run Output:

N/A (This fix is for help output handling which is already a local operation)

Checklist:

  • My code follows the AGENTS.md guidelines (no generated google-* crates).
  • I have run cargo fmt --all to format the code perfectly.
  • I have run cargo clippy -- -D warnings and resolved all warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have provided a Changeset file (e.g. via pnpx changeset) to document my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 1f9e964

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the gws auth setup command by introducing an early exit mechanism for help requests. It prevents the command from executing its main logic, which could lead to unwanted side effects like GCP project creation, when a user simply intends to view usage instructions.

Highlights

  • Help Flag Handling: Implemented explicit handling for --help and -h flags within the gws auth setup command.
  • Preventing Side Effects: Ensured that requesting help via these flags no longer triggers unintended operations, such as GCP project creation, improving user experience and preventing accidental resource provisioning.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the handling of --help and -h flags. No further specific comments are provided at this time, as suggestions for refactoring to use clap were deemed outside the primary scope of this pull request to prevent scope creep.

@googleworkspace-bot
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces explicit handling for the --help and -h flags within the gws auth setup command flow. The change is implemented correctly at the beginning of the run_setup function, ensuring that a usage message is printed and the program exits gracefully before any other logic is executed. This effectively prevents accidental side effects, such as triggering GCP project creation, when a user's intent is simply to view help information. The implementation is clear, directly addresses the stated issue, and I found no issues of high or critical severity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants