Skip to content

fix(formatter): correctly handle empty list responses from API#540

Open
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/formatter-empty-arrays-v3
Open

fix(formatter): correctly handle empty list responses from API#540
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/formatter-empty-arrays-v3

Conversation

@dumko2001
Copy link
Contributor

Description

Correctly identify and format empty API responses as (empty) instead of showing a confusing metadata table. This is achieved by allowing extract_items to return empty arrays, which triggers the proper list formatting logic.

Checklist:

  • My code follows the AGENTS.md guidelines (no generated google-* crates).
  • I have run cargo fmt --all to format the code perfectly.
  • I have run cargo clippy -- -D warnings and resolved all warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have provided a Changeset file (e.g. via pnpx changeset) to document my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 58a8563

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where empty list responses from the API were not formatted intuitively. By adjusting the extract_items function to correctly handle and return empty arrays, the system can now properly format these responses to display "(empty)", providing a clearer and less confusing output for users.

Highlights

  • API Response Formatting: Modified the extract_items function to allow it to return empty arrays, ensuring that API responses containing empty lists are now correctly identified and processed.
  • User Experience: Improved the display of empty API list responses, which will now show as "(empty)" instead of a potentially confusing metadata table, enhancing clarity for users.
  • Test Coverage: Updated the test_format_table_empty_array test case to assert the new expected output of "(empty)\n" for empty array responses, confirming the fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with formatting empty list responses from the API. The change modifies extract_items to return arrays even when they are empty, which allows downstream formatting logic to correctly handle these cases. A test has been updated to assert the new, correct behavior for table formatting, which now outputs (empty) for such responses. The changes appear to correctly fix the described issue.

@googleworkspace-bot
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the issue of handling empty list responses from the API. The modification in extract_items to allow empty arrays to be returned, combined with the updated test case, ensures that empty responses are now properly formatted as (empty) instead of a confusing metadata table. The changes are focused and directly resolve the described problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants