fix(auth): move keyring backend status message to debug log#545
fix(auth): move keyring backend status message to debug log#545dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e5dc99d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where a keyring backend status message was polluting Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where a status message about the keyring backend was always printed to stderr. The change correctly replaces the eprintln! call with a tracing::debug! log, which will prevent polluting output in automated environments. The implementation is straightforward and effectively resolves the issue described.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request changes the logging of the keyring backend status message from a direct stderr print to a debug-level log via the tracing crate. This change is intended to reduce output noise in automated environments. The implementation is correct and aligns with the stated goal. No issues were found in the changes.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly moves the keyring backend status message from a direct eprintln! to a tracing::debug! log. This change effectively reduces stderr noise in automated environments by leveraging the existing structured logging framework. The implementation is sound and well-focused. I have reviewed the changes and have no suggestions for improvement.
Description
Previously, the message indicating which keyring backend was being used was printed to
stderron every invocation. This pollutes the output in automated environments and agent pipelines. This PR moves that message to a debug-level log using thetracingcrate.Checklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.