Skip to content

fix(auth): move keyring backend status message to debug log#545

Open
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/keyring-logging-v2
Open

fix(auth): move keyring backend status message to debug log#545
dumko2001 wants to merge 3 commits intogoogleworkspace:mainfrom
dumko2001:fix/keyring-logging-v2

Conversation

@dumko2001
Copy link
Contributor

@dumko2001 dumko2001 commented Mar 18, 2026

Description

Previously, the message indicating which keyring backend was being used was printed to stderr on every invocation. This pollutes the output in automated environments and agent pipelines. This PR moves that message to a debug-level log using the tracing crate.

Checklist:

  • My code follows the AGENTS.md guidelines (no generated google-* crates).
  • I have run cargo fmt --all to format the code perfectly.
  • I have run cargo clippy -- -D warnings and resolved all warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have provided a Changeset file (e.g. via pnpx changeset) to document my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: e5dc99d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a keyring backend status message was polluting stderr output during every invocation, particularly problematic in automated pipelines. The change reclassifies this message to a debug-level log, ensuring it only appears when debug logging is explicitly enabled, thereby cleaning up standard error streams.

Highlights

  • Logging Verbosity: Changed the keyring backend status message from being printed to stderr using eprintln! to a debug-level log using the tracing crate. This reduces output noise in automated environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where a status message about the keyring backend was always printed to stderr. The change correctly replaces the eprintln! call with a tracing::debug! log, which will prevent polluting output in automated environments. The implementation is straightforward and effectively resolves the issue described.

@googleworkspace-bot
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the logging of the keyring backend status message from a direct stderr print to a debug-level log via the tracing crate. This change is intended to reduce output noise in automated environments. The implementation is correct and aligns with the stated goal. No issues were found in the changes.

@googleworkspace-bot
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves the keyring backend status message from a direct eprintln! to a tracing::debug! log. This change effectively reduces stderr noise in automated environments by leveraging the existing structured logging framework. The implementation is sound and well-focused. I have reviewed the changes and have no suggestions for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants