fix(auth): add People and Meet scopes to login picker#565
fix(auth): add People and Meet scopes to login picker#565anshul-garg27 wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
The interactive scope selector and --full preset were missing scopes for People API (contacts) and Meet API (meetings.space.created), causing insufficient-scope errors when calling those services. - Add contacts and meetings.space.created to SCOPE_ENTRIES for the TUI picker - Add both to FULL_SCOPES so --full covers them - Map "meet" service to "meetings" scope prefix so -s meet works Closes googleworkspace#556
🦋 Changeset detectedLatest commit: 1fa1bd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the authentication process by integrating previously missing scopes for the Google People and Meet APIs. This ensures that users can successfully authenticate and utilize Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the necessary scopes for the Google People and Meet APIs to fix insufficient authentication scopes errors. The changes update FULL_SCOPES, the interactive scope picker, and add a service mapping for meet. A new test verifies this mapping. The implementation correctly addresses the described issue.
Summary
gws auth logindidn't offer scopes for People API or Meet API in the interactive picker, so users gotinsufficient authentication scopeserrors when callinggws peopleorgws meetcommands.contacts(People API) andmeetings.space.created(Meet API) to the TUI scope pickerFULL_SCOPESso--fullcovers themmeetservice name tomeetingsscope prefix so-s meetfilters correctlyCloses #556
Test plan
cargo test— 750 pass, 0 failcargo clippy -- -D warnings— cleanscope_matches_service_meet_meetingsverifies the mapping