Skip to content

Make SliceSplit generic in element type #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchajed merged 1 commit into from
May 8, 2025
Merged

Make SliceSplit generic in element type #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions goose_std.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ func BytesClone(b []byte) []byte {
//
// The capacity of the first slice overlaps with the second, so afterward it is
// no longer safe to append to the first slice.
//
// TODO: once goose supports it, make this function generic in the slice element
// type
func SliceSplit(xs []byte, n uint64) ([]byte, []byte) {
func SliceSplit[T any](xs []T, n uint64) ([]T, []T) {
// TODO: we could get ownership of xs's capacity if we could write xs[:n:n]
// (this would reset xs to have no extra capacity), but Goose doesn't
// support that.
Expand Down