This repository was archived by the owner on Jan 11, 2019. It is now read-only.
Handling for day-of-week spans ending in seven#12
Open
AirbornePorcine wants to merge 3 commits intogorhill:masterfrom
calgaryscientific:master
Open
Handling for day-of-week spans ending in seven#12AirbornePorcine wants to merge 3 commits intogorhill:masterfrom calgaryscientific:master
AirbornePorcine wants to merge 3 commits intogorhill:masterfrom
calgaryscientific:master
Conversation
|
@gorhill bump :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, day-of-week spans that end in seven (ie 5-7) will not generate any values when calling next. The underlying issue is that populateMany generates its list based on a for between min and max values, and we set Sunday/7 to be an equivalent max value of zero.
We weren't entirely sure how to fix it at that point, so we added a quick piece of logic to remap the zero value to six (Saturday) when the end of a day-of-week span is seven. Suggestions for a less hacky-feeling way of fixing this are welcome of course.