This repository was archived by the owner on Jan 11, 2019. It is now read-only.
Add Matches function#34
Open
fooksca wants to merge 1 commit intogorhill:masterfrom
HotelsDotCom:master
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a Matches() function to the Expression … Please could you consider merging it as we would like to use it to add functionality to another open source project.
I am a bit concerned about how you might feel about using the
expressionfield for thecronLine(it was unused) … you may have wanted to use the expanded expression in there. Am happy to change as you require.