Do not save after ReplaceModifiedPart#75
Conversation
|
I see your point, but if we remove "save" users will face another problem: You can try it yourself, you'll see what I'm talking about. I'll leave this pull request open for now. Maybe I'll disable this function if document is 'dirty'. Let me think about it. |
|
Yeah I see what you're saying, that makes sense. I like the idea of disabling it if the document is dirty. And by the way, besides this issue the rest of the functionality in this package is fantastic and I love using it! I just don't want anyone else to lose work like I did, that's all. |
|
Yes, sure. I don't want that either. I'll suggest you using your branch for now, while I'm trying to find time to fix the issue properly. |
|
I didn't realize that it'd been saved so I just closed the tab expecting to select No when it asked whether or not I wanted to save changes. But since the tab's state wasn't dirty it just closed immediately and I lost my changes forever. But yeah I expect that |
This is not at all expected in my opinion and actually caused me to lose a bit of work earlier. And on top of it not being expected, it also does not update the tab's dirty state correctly. I really think auto-saving after this command is dangerous and unneeded.