fix: remove erroneous -- from git checkout command#42
Open
saschabuehrle wants to merge 1 commit intogotempsh:mainfrom
Open
fix: remove erroneous -- from git checkout command#42saschabuehrle wants to merge 1 commit intogotempsh:mainfrom
saschabuehrle wants to merge 1 commit intogotempsh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#40 — Public repository deployments fail with
pathspec did not match any file(s) known to gitbecause thegit checkoutcommand places the commit SHA after--, which tells git to treat it as a pathspec (file path) instead of a commit reference.Fix
Remove the
--argument from thegit checkoutinvocation indownload_repo.rs. Per the git manual, arguments after--are interpreted as pathspecs, not as tree-ish references. The commit SHA should be passed directly togit checkoutwithout the--separator.Before:
git checkout -- <commit_sha>After:
git checkout <commit_sha>Testing
Verified locally that
git checkout <sha>correctly checks out the target commit, whereasgit checkout -- <sha>fails with the reported pathspec error when the SHA does not match a filename.Happy to address any feedback.
Greetings, saschabuehrle