Change value sent for 'None of the above' option for conditions#1904
Closed
Change value sent for 'None of the above' option for conditions#1904
Conversation
f882d49 to
e532cb7
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1904.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this pull request solve?
https://trello.com/c/2H6cVned/2228-routes-based-on-none-of-the-above-answers-do-not-work
When creating or updating a condition for an optional selection question, we've been saving the option 'None of the above' in our database as the answer value
none_of_the_above. This has had the effect of not functioning in forms runner, as it's compared to the actual answer valueNone of the above. This PR goes in hand with govuk-forms/forms-api#733 to ensure that theanswer value missingerror now avoids triggering when the answer value isNone of the above.The change in this PR makes sure that we're saving the answer value for a condition as
None of the abovewhich in turn means runner will correctly compare against the actual answer value when given.Things to consider when reviewing