Skip to content

Update non-Crown agreement#2746

Open
lfdebrux wants to merge 1 commit intomainfrom
ldeb-non-crown-agreement-1.1
Open

Update non-Crown agreement#2746
lfdebrux wants to merge 1 commit intomainfrom
ldeb-non-crown-agreement-1.1

Conversation

@lfdebrux
Copy link
Copy Markdown
Contributor

@lfdebrux lfdebrux commented May 1, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/3ee1CPQH

Update the non-Crown agreement to version 1.1.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux changed the title Update Non-Crown agreement Update non-Crown agreement May 1, 2026
@lfdebrux lfdebrux force-pushed the ldeb-non-crown-agreement-1.1 branch from b27d7b1 to b8d1eb8 Compare May 1, 2026 13:41
Comment thread app/views/mou_signatures/_non_crown_agreement_version_current.html.erb Outdated
Comment thread app/views/mou_signatures/_non_crown_agreement_version_current.html.erb Outdated
Update the text of the non-Crown agreement to version 1.1.
@lfdebrux lfdebrux force-pushed the ldeb-non-crown-agreement-1.1 branch from b8d1eb8 to ad919c5 Compare May 1, 2026 14:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2746.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@StephenGill
Copy link
Copy Markdown
Contributor

the link to the support form is showing as http://localhost:3002/support , but I'm guessing that's just because it's the preview environment?

Otherwise looks good to me.

@lfdebrux
Copy link
Copy Markdown
Contributor Author

lfdebrux commented May 1, 2026

the link to the support form is showing as http://localhost:3002/support , but I'm guessing that's just because it's the preview environment?

Yes, that is correct, the link to be to the appropriate URL for the product pages in the environment the admin app is deployed in. So it will be https://www.forms.service.gov.uk/support in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants