This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Add separate endpoint for add another answer report#723
Merged
stephencdaly merged 1 commit intomainfrom Apr 3, 2025
Merged
Conversation
The report to list forms with add another questions is shown on a different page to the main feature usage report. The feature report in forms-admin now sources its data from the `/api/v2/form_documents` endpoint rather than `/api/v1/reports/features`. So that we can remove `/api/v1/reports/features`, separate the report to list forms with add another answer questions into its own endpoint. We can remove `/features` once forms-admin is using this new endpoint.
stephencdaly
force-pushed
the
add-separate-endpoint-for-add-another-answer-report
branch
from
01dbe52 to
f2378c5
Compare
|
DavidBiddle
approved these changes
Apr 3, 2025
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
Code looks good and tested succesfully on my local machine with the corresponding forms-admin branch 🎉
stephencdaly
deleted the
add-separate-endpoint-for-add-another-answer-report
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
The report to list forms with add another questions is shown on a different page to the main feature usage report. The feature report in forms-admin now sources its data from the
/api/v2/form_documentsendpoint rather than/api/v1/reports/features.So that we can remove
/api/v1/reports/features, separate the report to list forms with add another answer questions into its own endpoint. We can remove/featuresonce forms-admin is using this new endpoint.Things to consider when reviewing