This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Merged
Conversation
DavidBiddle
approved these changes
Sep 26, 2025
Since Rails 8, the health check controller logs are filtered out from the log stream by default [[1]]. All our apps are now using Rails 8 and have `config.silence_healthcheck_path` enabled [[2]], so we stopped filtering out log lines containing `/up` in our log forwarding configuration [[3]]. However, this doesn't appear to have worked, as we are now seeing logs from the healthcheck controller. This is probably because of how Lograge works; this commit adds an additional configuration line to tell Lograge to ignore logs for the healthcheck controller, matching the Rails default. [1]: rails/rails#52789 [2]: https://guides.rubyonrails.org/configuring.html#config-silence-healthcheck-path [3]: govuk-forms/forms-deploy#1720
lfdebrux
force-pushed
the
ldeb-lograge-ignore-health-controller
branch
from
ccea01d to
f6d7ae3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Since Rails 8, the health check controller logs are filtered out from the log stream by default [1]. All our apps are now using Rails 8 and have
config.silence_healthcheck_pathenabled [2], so we stopped filtering out log lines containing/upin our log forwarding configuration [3].However, this doesn't appear to have worked, as we are now seeing logs from the healthcheck controller. This is probably because of how Lograge works; this commit adds an additional configuration line to tell Lograge to ignore logs for the healthcheck controller, matching the Rails default.
I've tested this in dev.
Things to consider when reviewing