Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Add lockfile checksums#832

Merged
lfdebrux merged 2 commits intomainfrom
ldeb-bundler-add-checksums
Sep 26, 2025
Merged

Add lockfile checksums#832
lfdebrux merged 2 commits intomainfrom
ldeb-bundler-add-checksums

Conversation

@lfdebrux
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Bundler 2.6 added support for checksum verification as an opt-in beta feature [1]. We're on Bundler 2.7 now, and there don't appear to be any major issues with this feature, and the next major version of Bundler will include checksums in lockfiles by default.

So, we should enable it for our apps, as it protects against (some kinds of) supply chain attacks.

This commit includes the changes after running

bundle lock --add-checksums

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Bundler 2.6 added support for checksum verification as an opt-in beta
feature [[1]]. We're on Bundler 2.7 now, and there don't appear to be
any major issues with this feature, and the next major version of
Bundler will include checksums in lockfiles by default.

So, we should enable it for our apps, as it protects against (some kinds
of) supply chain attacks.

This commit includes the changes after running

    bundle lock --add-checksums

[1]: https://bundler.io/blog/2024/12/19/bundler-v2-6.html
[2]: https://github.com/rubygems/rubygems/blob/master/doc/bundler/UPGRADING.md
It turns out it's a good idea to normalize the platforms in the lockfile
when adding checksums, this commit includes the changes from running

    bundle lock --normalize-platforms
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lfdebrux lfdebrux merged commit 182306e into main Sep 26, 2025
4 checks passed
@lfdebrux lfdebrux deleted the ldeb-bundler-add-checksums branch September 26, 2025 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants