Skip to content

fixup! Add fix for capybara/chromedriver issue#1162

Open
lfdebrux wants to merge 1 commit intomainfrom
ldeb-add-chromedriver-workaround
Open

fixup! Add fix for capybara/chromedriver issue#1162
lfdebrux wants to merge 1 commit intomainfrom
ldeb-add-chromedriver-workaround

Conversation

@lfdebrux
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

This was missed in PR #1145.

Things to consider when reviewing

  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

In commit 1d54c9b I added an RSpec support file to workaround issues
with Chromedriver, but I forgot to require it in the `rails_helper`, so
it wasn't taking effect.

This commit should actually make the workaround work now.
@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1162.www.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant