Update and correct ERD to Class Diagrams#211
Merged
Conversation
DavidBiddle
reviewed
Jun 3, 2025
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
@chao-xian this all looks reasonable to me, but I don't think it will get rid of the old files - I think you might need to rebase onto the latest main and delete them
These diagrams are not ERDs but in fact Class Diagrams. They also needed some useful context and instructions on how to update them.
chao-xian
force-pushed
the
add-model-diagrams
branch
from
4c21c23 to
43748cf
Compare
DavidBiddle
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These diagrams are not ERDs but in fact Class Diagrams. They also needed some useful context and instructions on how to update them.
Trello https://trello.com/c/ukndHQIK/2301-create-uml-and-sequence-diagrams-for-creating-welsh-forms
PR Checklist
- (ADR, decision-record, engagement, research)
What
Describe what you have changed and why.
How to review
Describe the steps required to test the changes.
For example:
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.