Skip to content

Document designs for file upload feature#220

Merged
deberny merged 15 commits intomainfrom
feature-file-upload-docs
Jul 14, 2025
Merged

Document designs for file upload feature#220
deberny merged 15 commits intomainfrom
feature-file-upload-docs

Conversation

@deberny
Copy link
Copy Markdown
Contributor

@deberny deberny commented Jul 9, 2025

PR Checklist

  • If you are proposing a new decision record document, used the right template for that
    - (ADR, decision-record, engagement, research)
  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

Describe what you have changed and why.

How to review

Describe the steps required to test the changes.

For example:

  1. Semantic: Do you agree with the changes?
  2. Syntactic: Spelling, grammar, etc.

Who can review

Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.

deberny and others added 4 commits July 9, 2025 15:39
Added main content from the design doc and referenced screenshots.

Needs adding contents with links

Co-Authored-By: william-castoncook <169675451+william-castoncook@users.noreply.github.com>
Co-Authored-By: william-castoncook <169675451+william-castoncook@users.noreply.github.com>
@deberny deberny marked this pull request as ready for review July 10, 2025 10:00
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
Comment thread design/features/file-upload/README.md Outdated
deberny and others added 11 commits July 14, 2025 14:02
Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
fix typo

Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
remove unnecessary link

Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Lot's of useful suggestions and fixes

Co-authored-by: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Co-Authored-By: Christopher Cameron <35372982+christophercameron-ixd@users.noreply.github.com>
Access to the mural is restricted to people in our workspace, so it's safe to publish the link.
Removed an unfinished sentence and added a line on what we want to do next.
Copy link
Copy Markdown
Contributor

@william-castoncook william-castoncook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deberny deberny merged commit 73baf8d into main Jul 14, 2025
@deberny deberny deleted the feature-file-upload-docs branch July 14, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants