Skip to content

Create ADR for proposed Welsh forms API implementation#222

Merged
DavidBiddle merged 2 commits intomainfrom
DavidBiddle-patch-1
Aug 20, 2025
Merged

Create ADR for proposed Welsh forms API implementation#222
DavidBiddle merged 2 commits intomainfrom
DavidBiddle-patch-1

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Aug 1, 2025

PR Checklist

  • If you are proposing a new decision record document, used the right template for that
    - (ADR, decision-record, engagement, research)
  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

Proposes an approach for how forms-runner gets translated forms from forms-api.

Outcome of spike: https://trello.com/c/Ok9i8oup/2401-spike-how-will-forms-runner-get-translated-forms-from-forms-api

When to review

Ideally I'd like to have a card for implementing this ready by the end of sprint 24, so reviews by Wednesday 13 August would be ideal if possible 💐

How to review

  1. Semantic: Do you agree with the changes? Does the recommended approach make sense to you?
  2. Syntactic: Spelling, grammar, etc.

Who can review

Anyone

@DavidBiddle
Copy link
Copy Markdown
Contributor Author

DavidBiddle commented Aug 1, 2025

Spike branches for option 1:

Spike branches for option 2:

Both spikes use a rebased version of the original Mobility spike branch as a base.

There's no spike branch for option 3 at the moment - I thought of this after I'd investigated and started writing up the other two, and it's a lot more complex to look into. If people think it's a better approach than the one proposed in this ADR, we can make a spike branch to investigate it further next week. The runner implementation would be the same aas option 2, but I think we'd have to make quite a few changes in admin and API.

@DavidBiddle DavidBiddle requested a review from a team August 1, 2025 13:30
@DavidBiddle DavidBiddle self-assigned this Aug 1, 2025
Comment thread ADR/ADR044-translate-api-response-at-request-time.md
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
@DavidBiddle DavidBiddle marked this pull request as ready for review August 4, 2025 09:02
Comment thread ADR/ADR044-translate-api-response-at-request-time.md
@DavidBiddle DavidBiddle force-pushed the DavidBiddle-patch-1 branch 3 times, most recently from d124f2b to d0545d3 Compare August 7, 2025 15:28
Comment thread ADR/ADR044-translate-api-response-at-request-time.md
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
Comment thread ADR/ADR044-translate-api-response-at-request-time.md
Comment thread ADR/ADR044-translate-api-response-at-request-time.md Outdated
@DavidBiddle DavidBiddle force-pushed the DavidBiddle-patch-1 branch 3 times, most recently from 405f2b3 to dc55ba2 Compare August 14, 2025 15:39
@DavidBiddle DavidBiddle merged commit dff55bc into main Aug 20, 2025
@DavidBiddle DavidBiddle deleted the DavidBiddle-patch-1 branch August 20, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants