Create ADR for proposed Welsh forms API implementation#222
Merged
DavidBiddle merged 2 commits intomainfrom Aug 20, 2025
Merged
Conversation
Contributor
Author
|
Spike branches for option 1:
Spike branches for option 2:
Both spikes use a rebased version of the original Mobility spike branch as a base. There's no spike branch for option 3 at the moment - I thought of this after I'd investigated and started writing up the other two, and it's a lot more complex to look into. If people think it's a better approach than the one proposed in this ADR, we can make a spike branch to investigate it further next week. The runner implementation would be the same aas option 2, but I think we'd have to make quite a few changes in admin and API. |
thomasiles
reviewed
Aug 6, 2025
d124f2b to
d0545d3
Compare
lfdebrux
reviewed
Aug 11, 2025
lfdebrux
reviewed
Aug 11, 2025
lfdebrux
reviewed
Aug 11, 2025
0e814cc to
a04d28f
Compare
lfdebrux
reviewed
Aug 14, 2025
lfdebrux
reviewed
Aug 14, 2025
405f2b3 to
dc55ba2
Compare
dc55ba2 to
3b47dca
Compare
theseanything
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
- (ADR, decision-record, engagement, research)
What
Proposes an approach for how forms-runner gets translated forms from forms-api.
Outcome of spike: https://trello.com/c/Ok9i8oup/2401-spike-how-will-forms-runner-get-translated-forms-from-forms-api
When to review
Ideally I'd like to have a card for implementing this ready by the end of sprint 24, so reviews by Wednesday 13 August would be ideal if possible 💐
How to review
Who can review
Anyone