Add Node.js and Python examples to filter-session-intro #44
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Node.js and Python code examples to the existing C-only filter session tutorial documentation. The changes create multi-language tabs showing equivalent functionality across all three programming languages for creating and using GPAC FilterSession objects.
- Adds tabbed code examples for Node.js and Python alongside existing C examples
- Demonstrates creating FilterSession objects, loading filters, and running sessions in all three languages
- Includes complete sample code implementations showing a full filter pipeline workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| mkdocs.yml | Enables tabbed code blocks extension for multi-language documentation |
| docs/Developers/tutorials/filter-session-intro.md | Adds Node.js and Python examples throughout the FilterSession tutorial |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| === "NodeJS" | ||
|
|
||
| ```javascript | ||
| const gpac = require(path/to/gpac/share/nodejs); |
There was a problem hiding this comment.
Missing quotes around the path in the require statement. Should be require('path/to/gpac/share/nodejs')
| const gpac = require(path/to/gpac/share/nodejs); | |
| const gpac = require('path/to/gpac/share/nodejs'); |
|
|
||
| ```javascript | ||
|
|
||
| const gpac = require(path/to/gpac/share/nodejs); |
There was a problem hiding this comment.
Missing quotes around the path in the require statement. Should be require('path/to/gpac/share/nodejs')
| const gpac = require(path/to/gpac/share/nodejs); | |
| const gpac = require('path/to/gpac/share/nodejs'); |
| dst_filter.set_source(writegen_filter); | ||
|
|
||
|
|
||
| session.run(); |
There was a problem hiding this comment.
The variable err is referenced but not assigned from the session.run() call. Should be const err = session.run();
| session.run(); | |
| const err = session.run(); |
|
Loving this, great addition ! |
2 participants
Added a minimal Node.js & Python examples to create and run a FilterSession.